From f3be3eba84b17907b827b8b9bc26f983406191fb Mon Sep 17 00:00:00 2001 From: sneak Date: Wed, 17 Dec 2025 11:22:58 -0800 Subject: [PATCH] Add TODO: change FileProgress callback to channel-based --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 21a825e..18e39e9 100644 --- a/README.md +++ b/README.md @@ -361,6 +361,7 @@ The manifest file would do several important things: - [ ] **Add `--force` flag for overwrites** - Currently silently overwrites existing manifest files. Should require `-f` to overwrite. - [ ] **Implement FollowSymLinks option** - The flag exists in CLI and Options structs but does nothing. Scanner should use `EvalSymlinks` or `Lstat`. +- [ ] **Change FileProgress callback to channel** - `mfer/builder.go` uses a callback for progress reporting; should use channels like `EnumerateStatus` and `ScanStatus` for consistency. - [ ] **Consolidate legacy manifest code** - `mfer/manifest.go` has old scanning code (`Scan()`, `addFile()`, `generateInner()`) that duplicates the new `internal/scanner` + `mfer/builder.go` pattern. - [ ] **Add context cancellation to legacy code** - The old `manifest.Scan()` doesn't support context cancellation; the new scanner does.